Hi Niall, thank you for your comments - please see my response in line.
Jan Niall Power wrote: > Hi Jan, > > Overall the design looks solid to me. One major point I'm not convinced about > is the > idea of having separate logging and debugging services. What is the advantage > of > separating them out? On the list of disadvantages I see the following: > - It doesn't seem unified to output to 2 separate destinations. The reason why it was decided to have two separate "capture streams" is that each of the service hits different target group of consumers - users and developers. Since log file can be displayed directly from installer and thus is visible to regular user, it was considered that it would contain only messages providing status and progress of the installation process and should have relatively high signal to noise ratio from user's point of view. Also at some point it was being discussed that since these messages can be displayed from within installer, they could be localized. On the other hand, debugging service was designed to provide installer with possibility to capture all information necessary for engineer to track down cause of potential issue - it thus might contain a lot of information which might be useless or even misleading to the user. And these kind of messages are not subject of localization process. > - The debug log doesn't get preserved after installation. A debug log may > contain key > pieces of information that the other log file doesn't. For hard to > reproduce bugs etc. > the debug log may be all we have to go on if the problem can't be > reproduced internally. Agreed - if we decide we will continue to use two separate files, they both will have to be preserved - the orchestrator would take care of this. > - Data may get logged inappropriately because it is up each individual > working on different > parts of the code to decide whether a particular event or situation is a > logging or a debugging > situation. Things could become inconsistent quite easily. This is good point - actually this reason is why I am not quite convinced that using two separate files is perfect solution. For now there are no strict criteria, which might be followed when this kind of decision has to be made. But I think we will need to make this decision, even if we use one common logging service (for example by setting message verbosity level), since I think that debug messages should remain hidden to the user by default. > > Thanks, > Niall. > -- > This message posted from opensolaris.org > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
