Hi Dave,
Dave Miner wrote: > I don't see much reason for having separate log files for debug and > non-debug levels. One reason to unify logging is to avoid users, > support personnel, or developers piecing things together from multiple > sources; having to do so in a debugging situation seems > counter-productive. We were oscillating between having one unified file and having separate file for debug messages for a while. Now after obtaining more opinions on this topic, I can see that having one common source is better way to follow - I will modify design spec appropriately. > > One other comment I'll make is that I don't see the need for the > 'trace' level of debugging; we've been actively removing this sort of > thing from other components (recently done to inetd) because it's > duplicative with truss and DTrace. This is good point - I will remove the "trace" level from logging service. > > I'd suggest that you're missing a couple of API's here, which would be > the ones which close and move the log file into the installed > filesystem hierarchy. This properly encapsulates the function so that > the orchestrator or other levels don't have to know the details of the > logging implementation. Thank you for pointing this out - I didn't realize it. I will add these interfaces to the design spec. Also I will go through the modules which use logging service for now and take a look if anything else is missing. Thank you very much for your comments, Jan
