Hi Dave, thank you very much for your comments. Please see my response below.
Jan Dave Miner wrote: > jan damborsky wrote: >> Hi Sundar, >> >> could I please ask you to review changes for >> following bug ? >> >> 683 orchestrator should be libspmi* clean >> http://defect.opensolaris.org/bz/show_bug.cgi?id=683 >> >> Webrev is available at >> http://cr.opensolaris.org/~dambi/bug-683/ >> >> If anybody else would like to take a look, >> it will be appreciated. >> > > usr/src/lib/liborchestrator/upgrade_targets.c > > Why not just get rid of om_is_upgrade_target_valid()? There's only a > couple of calls to it. Or are we expecting to put in a new > implementation later? Yes, the reason why it is not completely removed for now is that it is assumed om_is_upgrade_target_valid() would contain new validation code if it is decided that upgrade path will be supported in some way in GUI installer. Please see my response to Jack's comments for more detailed explanation. > > usr/src/lib/libtd/Makefile > > I'm assuming there's another bug coming to make TD independent of > libspmi? Yes - since the final goal is to completely get rid of libspmi* libraries in new installer, TD service will be modified as well - I will file bug for this. Jan
