Hi Sundar, thank you very much for your comments. Please see me response in line.
Jan Sundar Yamunachari wrote: > jan damborsky wrote: >> Hi Sundar, >> >> could I please ask you to review changes for >> following bug ? >> >> 683 orchestrator should be libspmi* clean >> http://defect.opensolaris.org/bz/show_bug.cgi?id=683 >> >> Webrev is available at >> http://cr.opensolaris.org/~dambi/bug-683/ >> >> If anybody else would like to take a look, >> it will be appreciated. >> >> Thank you very much, >> Jan >> >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >> > *usr/src/lib/liborchestrator/locale.c: > > *1831: There are two definitions for "/a" (MOUNTA and > INSTALLED_ROOTDIR) in orchestrator_private.h. Can we get rid of one of > the definition? Done - I switched to INSTALLED_ROOT_DIR and removed MOUNTA. > > *usr/src/lib/liborchestrator/upgrade_targets.c: > > *174: can we get rid of om_is_upgrade_target_valid()? Is GUI using > this api? om_is_upgrade_target_valid() is currently called from GUI function upgrade-screen:validate_upgrade_target(). Since I am not sure if upgrade feature might be reenabled at some point in GUI installer, I didn't remove all references to upgrade code - please see my response to Jack's comments for more detailed explanation.
