Hi Alex,

I have gone through the updated webrev and it looks
almost good, I have only couple of nits to be addressed
(please see below).

Thank you,
Jan

td_mountall.c
-------------

Since following functions are now unused, could you please
completely remove them from td_mountall.c, td_util.c and td_lib.h ?

* td_umount_and_delete_swap()
* td_unswap_all()
* td_delete_all_swap()


lines 864, 865 - comment is not correctly aligned - 'hg pbchk' reported:

$ hg pbchk
...
C style check:
lib/libtd/td_mountall.c: 864: improper block comment
lib/libtd/td_mountall.c: 865: improper block comment close
...



Alexander Eremin wrote:
> Hi Jan!
> All test now ok.
> After tdmgtst ends -
> on SXCE
>  swap from vfstab is present
>  manually added swap is present
>  no new mountpoints
>
> Booting from LiveCD:
> After tdmgtst ends -
> manually added swap is present
> no new mountpoints in /tmp
>
> Updated webrev is here: http://cr.opensolaris.org/~alhazred/7915/


Reply via email to