In final testing over the weekend I found that I had a problem with the fix. If the mountpoint for the pool being used was not the same as the name of the pool then the ICT call would fail to create menu.lst. The causes for this were due to two problems. First I was passing the name of the pool to the add_splash_image_to_grub_menu ICT. This should have been passing the mountpoint of the pool and not the pool name. Secondly in the ICT it was always pulling the name of the pool out of /etc/mnttab and using that as the mountpoint for the pool when creating the menu.lst. This is normally OK for an install, however when running on an installed system the pools' mountpoint can be different than the name.
I've made these changes and retested, the fix now passes this test as well. The webrev with just these changes is at: http://cr.opensolaris.org/~evanl/7880v3/ Thanks! -evan Joseph J VLcek wrote: > Evan Layton wrote: >> Joseph J VLcek wrote: >>> Evan Layton wrote: >>>> I need to get reviews for the following bugs that are causing failures >>>> if the directories where the boot/grub menu files live are missing >>>> (/rpool/boot and /rpool/boot/grub). Also this fix resolves the issue >>>> with the add_splash_image_to_grub_menu that was causing a failure to >>>> create a menu.lst file when it's missing. >>>> >>>> >>>> The bugs: >>>> http://defect.opensolaris.org/bz/show_bug.cgi?id=7880 >>>> http://defect.opensolaris.org/bz/show_bug.cgi?id=11436 >>>> >>>> >>>> The webrev: >>>> http://cr.opensolaris.org/~evanl/7880/ >>>> >>>> >>>> Thanks, >>>> -evan >>>> >>>> _______________________________________________ >>>> caiman-discuss mailing list >>>> caiman-discuss at opensolaris.org >>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>> >>> ict.py >>> >>> Issue: >>> ------ >>> >>> 305 order to protect against accidental usage durring >> >> Fixed >> >>> >>> durring -> during >>> >>> Issue: >>> ------ >>> >>> 312 >>> nit: unnecessary blank line >>> >> >> Fixed >> >> >>> Issue: >>> ------ >>> >>> 333 if ((self.LIVECD_INSTALL) or (self.AUTO_INSTALL)): >>> 334 self.BOOTENVRC = BASEDIR + BOOTENVRC #/boot/solaris/bootenv.rc >>> 335 else: >>> 336 self.BOOTENVRC = BOOTENVRC #/boot/solaris/bootenv.rc >>> >>> Please add a comment describing the condition where this code is >>> required. >> >> Removed the comments at the end of these lines ad added a block >> comment before >> this section of code: >> >> ''' >> If we're running outside of an install we should not use >> the basdir here since that could be the mounpoint of a >> pool that we're creating the menu.lst file on. >> ''' >> >> >> I've updated the code and posted an updated webrev at: >> http://cr.opensolaris.org/~evanl/7880v2/ >> >> >> Thanks everyone for the comments! >> >> -evan > > > Thanks for making those changes Evan. It looks OK to me now. > > Joe
