Sarah Jelinek wrote: > Hi Evan, > > Looks ok. I do have a question: > > Why do we have this check: >> if ((self.LIVECD_INSTALL) or (self.AUTO_INSTALL)): >> 365 self.AUTOHOME = BASEDIR + AUTOHOME >> 366 else: >> 367 self.AUTOHOME = AUTOHOME >> 368 > > In ict.py? > > And, what happens when we add the text installer product? Don't we have > to modify this to include a check for that?
Yes but this is not the only use of these two checks and this was already being used in ict.py. Also there is a check that will be added by the fix for 7880/11436 that uses these for dealing with the grub menu. All of these areas will need to be updated to add the text installer. -evan > > thanks, > sarah > **** > > Evan Layton wrote: >> I need a couple of reviews for the fix to bug 364. This fix sets >> the users home directory to /home/<user_name> instead of >> /export/home/<user_name>. It then adds the "* >> localhost:/export/home/&" >> line to /etc/auto_home so that /home/<user_name> is auto-mounted on >> /export/home/<user_name>. >> >> The bug: >> http://defect.opensolaris.org/bz/show_bug.cgi?id=364 >> >> The webrev: >> http://cr.opensolaris.org/~evanl/364/ >> >> This ICT was tested from the command line as well as from >> an install. >> >> Thanks! >> -evan >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
