Dave Miner wrote: > Jack Schwartz wrote: >> Hi Sarah and Evan. >> >> On 10/13/09 06:44, Sarah Jelinek wrote: >>> Hi Evan, >>> >>> Looks ok. I do have a question: >>> >>> Why do we have this check: >>>> if ((self.LIVECD_INSTALL) or (self.AUTO_INSTALL)): >>>> 365 self.AUTOHOME = BASEDIR + AUTOHOME >>>> 366 else: >>>> 367 self.AUTOHOME = AUTOHOME >>>> 368 >>> >>> In ict.py? >>> >>> And, what happens when we add the text installer product? Don't we >>> have to modify this to include a check for that? >> Text-install image does introduce a third type here. I'll address >> this as part of the text-installer modification (part of the >> text-mode-menu work I've got for Driver Update). >> > > I think the real question is why this is attempting to differentiate at > all. In what situations would this ever be called that BASEDIR > shouldn't be prepended?
I can't think of one currently however it is conceivable that we may want to run this outside of the installer similar to add_splash_to_menu. If that is the case then we would not want to prepend BASEDIR. It was for this possibility that I added this check. -evan > > Dave
