Hi Sriman,

I updated bug 7877 before I saw this code review request with some
concerns about the approach taken for this bug. I'm not sure that we
want to skip the be_get_uuid call and subsequent check for every
instance where BE_MOUNT_FLAG_NO_ZONES is set. I can't think of any
instances off the top of my head where this might be the case but
I'm not comfortable with the idea of impacting all of the _be_mount
calls in this way. Before doing this we should make sure we really
want to remove this uuid check for every instance where
BE_MOUNT_FLAG_NO_ZONES is set.

Thanks!
-evan

sriman narayana bhavanam - Sun Microsystems - Bangalore India wrote:
> Hi,
> 
> Could you please review my changes to fix CRs - 8006, 7877 and let me 
> know your comments.
> 
> 
> bug report :http://defect.opensolaris.org/bz/show_bug.cgi?id=8006
>                  http://defect.opensolaris.org/bz/show_bug.cgi?id=7877
> 
> Webrev     : http://cr.opensolaris.org/~sb229247/caiman-8006/
> 
> 
> Thanks you very much,
> 
> -Sriman
> 
> _______________________________________________
> caiman-discuss mailing list
> caiman-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss


  • [caiman-disc... sriman narayana bhavanam - Sun Microsystems - Bangalore India
    • [caiman... Evan Layton
    • [caiman... Ethan Quach
      • [ca... sriman narayana bhavanam - Sun Microsystems - Bangalore India
        • ... Ethan Quach
          • ... sriman narayana bhavanam - Sun Microsystems - Bangalore India
            • ... sriman narayana bhavanam - Sun Microsystems - Bangalore India

Reply via email to