sriman narayana bhavanam - Sun Microsystems - Bangalore India wrote:
>>
>> libbe.h
>> -------
>> Per the comment at 67, can you move this to the end of the enum
>> and make the corresponding change to messages.py
> I changed it as per your suggestion. But, I would like to understand the
> rationale behind the comment at line 67. Why is it necessary to add 
> messages
> at the end of enum to keep them in sync.
> 
> Is it not Ok if we add new messages at same position in both libebe.h 
> and messages.py?
> I am asking this for my own understanding.

In general circumstances that is Ok, but we've had cases where
we've had to backpublish libbe to an older build, and though we never
expect to have to do this, when we do, limiting what we *have* to
backpublish is a plus.

> 
> Updated Webrev : http://cr.opensolaris.org/~sb229247/caiman-8006/

Looks okay.


thanks,
-ethan

  • [caiman-disc... sriman narayana bhavanam - Sun Microsystems - Bangalore India
    • [caiman... Evan Layton
    • [caiman... Ethan Quach
      • [ca... sriman narayana bhavanam - Sun Microsystems - Bangalore India
        • ... Ethan Quach
          • ... sriman narayana bhavanam - Sun Microsystems - Bangalore India
            • ... sriman narayana bhavanam - Sun Microsystems - Bangalore India

Reply via email to