Hi Jean, I have only nit - following definition can be also removed from orchestrator_private.h:
#define PROFILE_NAME "profile" I am sorry as I have overlooked this initially. Other than that the changes look good - no need for another round of code review. Thank you very much, Jan Jean McCormack wrote: > Jean McCormack wrote: >> Jan Damborsky wrote: >>> Hi Jean, >>> >>> looking at webrev files, there seem to be couple of additional >>> pfinstall/SXDE related remnants (please see attached diff). Could >>> you please remove them as well ? >>> Other than that, the changes look good. >> Sure. I didn't realize those were pfinstall. I'll look into removing >> them and making sure they're not used anywhere. >> >> Jean >> >> > I've created a new webrev to reflect Jan's requested changes. > > http://cr.opensolaris.org/~jeanm/slim_789_2/ > > Jean > >>> >>> Thank you, >>> Jan >>> >>> >>> Jean McCormack wrote: >>>> I'd like a code review for 789 Remove the pfinstall references in >>>> liborchestrator >>>> >>>> Webrev: >>>> http://cr.opensolaris.org/~jeanm/slim_789/ >>>> >>>> CR: >>>> http://defect.opensolaris.org/bz/show_bug.cgi?id=789 >>>> >>>> Jean >>>> _______________________________________________ >>>> caiman-discuss mailing list >>>> caiman-discuss at opensolaris.org >>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>> >> >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >
