Hi Jedy, The changes look fine to me but I did notice a typo in confirmation-screen.c:
224 g_object_set(G_OBJECT(detailLabel), "can-foucs", TRUE, NULL); "can-foucs" should be "can-focus" Thanks, Niall. Jedy Wang wrote: > Hi all, > > The fix uses GtkFrame to replace GtkBox/GtkTable to provide more clear > relationship between widgets. So Orca screen reader will read the > content in a more reasonable way (Read the label of GtkFrame when a > widget in the GtkFrame has the focus). And because the type of some > widgets is changed, I also renamed some variables and removed some used > variables. > > Because of the adoption of GtkFrame, the layout is changed a little bit. > You can find the screenshots before and after applying the fix in the > bug report. > > You can find the bug report at > http://defect.opensolaris.org/bz/show_bug.cgi?id=3797 > and webrev at > http://cr.opensolaris.org/~jedy/3797/ > > Regards, > > Jedy > >
