It was my problem.Guess I'm still suffering side effects from this morning's dental work. ;-)
I was commenting on the spacing for the Users screen, 5728. I'm fine with the spacing changes on the Summary screen, 3797. Frank Willie Walker wrote: > My eyes and mind might be tired, so I might be looking at the > screenshots incorrectly. It looks to me, however, as though the patch > actually increases the spacing: > > Old: http://defect.opensolaris.org/bz/attachment.cgi?id=1144 > New: http://defect.opensolaris.org/bz/attachment.cgi?id=1145 > > Will > > Frank Ludolph wrote: >> Jedy, >> >> Thanks for posting the before and after screenshots. The spacing is >> definitely a little crunched. It would be good if it could be opened >> up, say by inserting some small empty gifs or something (provided >> this doesn't affect ORCA), but it is marginally acceptable as is. >> >> Frank >> >> >> Jedy Wang wrote: >>> Thanks, Niall. I Will fix the problem. If Frank has no problem with the >>> layout changes, I will commit my patch. >>> >>> Regards, >>> >>> Jedy >>> On Wed, 2008-12-10 at 12:46 +0000, Niall Power wrote: >>> >>>> Hi Jedy, >>>> >>>> The changes look fine to me but I did notice a typo in >>>> confirmation-screen.c: >>>> >>>> 224 g_object_set(G_OBJECT(detailLabel), "can-foucs", TRUE, >>>> NULL); >>>> >>>> >>>> "can-foucs" should be "can-focus" >>>> >>>> Thanks, >>>> Niall. >>>> >>>> >>>> Jedy Wang wrote: >>>> >>>>> Hi all, >>>>> >>>>> The fix uses GtkFrame to replace GtkBox/GtkTable to provide more >>>>> clear >>>>> relationship between widgets. So Orca screen reader will read the >>>>> content in a more reasonable way (Read the label of GtkFrame when a >>>>> widget in the GtkFrame has the focus). And because the type of some >>>>> widgets is changed, I also renamed some variables and removed some >>>>> used >>>>> variables. >>>>> >>>>> Because of the adoption of GtkFrame, the layout is changed a >>>>> little bit. >>>>> You can find the screenshots before and after applying the fix in the >>>>> bug report. >>>>> >>>>> You can find the bug report at >>>>> http://defect.opensolaris.org/bz/show_bug.cgi?id=3797 >>>>> and webrev at >>>>> http://cr.opensolaris.org/~jedy/3797/ >>>>> >>>>> Regards, >>>>> >>>>> Jedy >>>>> >>>>> >>> >>> >> >
