On Tue, 26 Jan 2010, Ethan Quach wrote: > Can I get two reviews for this. > > These fixes are going to change the way we require booting > Sparc and X86 over the network to instantiate an automated > install. Flag days will be sent out. > > Webrev: > ------------ > http://cr.opensolaris.org/~equach/webrev.14082.13766.4069/ > > Defects: > ------------ > http://defect.opensolaris.org/bz/show_bug.cgi?id=14082 > http://defect.opensolaris.org/bz/show_bug.cgi?id=13766 > http://defect.opensolaris.org/bz/show_bug.cgi?id=4069
auto-installer: line 124: Where is SMF_FMRI defined? (I don't think it is). Also, do you want it to be AI_SMF_FMRI instead? manifest-locator: lines 207-239: So "install prompt" aren't positional any more? That is, "boot cdrom - prompt install" would also have the same effect. manifest-locator: line 243: Remove the use of $HEAD, yields the same results. manifest-locator: line 272-274: This may be good to document in the formal documents. manifest-locator: line 302: I trust you've reworked this piece so the correct check happens for x86? dc_defs.py: Why bother setting the do_safe_default keyword in DC and propagate it via the .image_info file? Why not just always create a safe default GRUB menu entry especially since we don't provide a user visible way to tweak DC to not be the case? installadm-common.sh: line 520, 524: s/automated/automated install installadm.1m.txt: Do we also want to document here how to change the default GRUB menu entry to do a hands free install? Alok
