Jan, Thanks for the comments.
-ethan On 01/27/10 00:51, Jan Damborsky wrote: > Hi Ethan, > > I looked at updated webrev and I have just couple of nits - > please see below. No need for another webrev. > > Thank you, > Jan > > > auto-installer > -------------- > 90,101,108 - '\' is redundant, can be removed > 91,102,109 - bad indentation - should be 4 spaces > > 117 echo "The progress of the Automated Installation can be followed by > viewing " \ > -> > 117 echo "The progress of the Automated Installation can be followed by > viewing" \ > > > manifest-locator > ---------------- > > 284 if [ ! -z "$INSTALL_DEBUG_MODE" ] ; then > -> > 284 if [ -n "$INSTALL_DEBUG_MODE" ] ; then > > 285,323 - '\' is redundant, can be removed > > 301 echo "Auto-installer disabled. Enable the auto-installer service" | \ > -> > 301 echo "Auto-installer disabled. Enable the auto-installer service" | > > 334 echo "Using the configuration manifest obtained via service " \ > -> > 334 echo "Using the configuration manifest obtained via service" \ > > > installadm-common.sh > -------------------- > > 386 # $ - path to image > -> > 386 # $1 - path to image > > > > > On 01/26/10 08:57 PM, Ethan Quach wrote: >> Can I get two reviews for this. >> >> These fixes are going to change the way we require booting >> Sparc and X86 over the network to instantiate an automated >> install. Flag days will be sent out. >> >> Webrev: >> ------------ >> http://cr.opensolaris.org/~equach/webrev.14082.13766.4069/ >> >> Defects: >> ------------ >> http://defect.opensolaris.org/bz/show_bug.cgi?id=14082 >> http://defect.opensolaris.org/bz/show_bug.cgi?id=13766 >> http://defect.opensolaris.org/bz/show_bug.cgi?id=4069 >> >> >> Tested scenarios: >> ----------------------------- >> x86: boot from media >> - all choices selected >> boot from network >> - both choices selected >> >> sparc: boot from media and network >> " boot <dev> - install" >> " boot <dev> - install prompt" >> " boot <dev> - install prompt install_debug" >> " boot <dev>" >> " boot <dev> - prompt" >> >> AI server: create-service >> create-client >> pre-132 server -- 132 image >> 132 server -- pre-132 image >> 132 server -- 132 image >> >> >> >> Proposed Flag day messages below: >> >> >> Flag Day: AI Sparc bootargs when booting from network >> ------------------------------------------------------------------------------------------------ >> If you don't use the automated installer on Sparc systems, ignore >> this message. With the fixes for the following bugs: >> >> 14082 bootarg for booting automated installs over the network >> 13766 AI debug mode can only be activated in conjunction with service >> discovery >> 4069 The create-service setup doesn't work if a client is booted using >> a tip line >> >> A change in build 132 is that Sparc booting will *require* a bootarg >> to trigger the Automated Install. This new required bootarg is >> named "install", as the following: >> >> ok > boot net:dhcp - install >> >> Without the "install" bootarg, the system will boot into the AI boot >> image and present console-login, but automated installation will >> not start. >> >> In addition, there is now a bootarg to enable debug mode for >> the automated installer. This new bootarg is named "install_debug" >> and can be used as such: >> >> ok > boot net:dhcp - install install_debug >> >> >> Reasons: >> -------------- >> 1. Makes it consistent with bootargs required when booting AI >> from media. i.e. >> >> ok> boot cdrom - install >> >> 2. Familiar bootarg name used with previous hands-free installation >> method, i.e. jumpstart. >> >> 3. Prevents the case where system may accidentally boot into the >> net device, and an auto installation runs and wipes out the disk. >> >> 4. Also see defect 14082. >> >> >> >> >> Flag Day: AI x86 default behavior when booting from network >> --------------------------------------------------------------------------------------------------------- >> If you don't use the automated installer on x86 systems, ignore >> this message. With the fixes for the following bugs: >> >> 14082 bootarg for booting automated installs over the network >> 13766 AI debug mode can only be activated in conjunction with service >> discovery >> 4069 The create-service setup doesn't work if a client is booted using >> a tip line >> >> In build 132, the default behavior of booting x86 systems over the >> network into AI images has changed. The default grub menu entry >> will no longer start a hands-free automated install. The second >> entry must selected to kick off the hands-free install. >> >> >> AI server bld AI image bld Required action >> --------------------- ---------------------- ---------------------------- >> pre 132 pre 132 No change. >> >> pre 132 132 or later Clients booting this image will not >> automatically boot into a hands- >> free automated install. The work- >> around is manual. You must hand >> edit the menu.lst file associated with >> the service and add a "install=true" >> property to the -B args, or add this >> to the menu entry at boot time. >> >> 132 or later pre 132 No change. >> >> 132 or later 132 or later Clients booting this image will not >> automatically boot into a hands- >> free automated install. This is the >> desired new changed behavior. The >> second grub menu option must be >> chosen to kick off the hands-free >> install. Alternatively, you can use the >> -b option with 'create-service' or >> 'create-client' to explicitly add the >> "install=true" flag into the menu, >> which will cause the default entry to >> do a hands-free install. >> >> installadm create-service ... -b install=true >> installadm create-client ... -b install=true ... >> >> >> >> >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss > > > > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
