Sorry for missing this earlier. But in ti_dm.c, (line 1503), creating the EFI label should only occur when errno is ENOTSUP. The return values from the ioctl can be EINVAL or ENOTSUP. You might want to filter and provide info for both these conditions.
-Sanjay On 02/16/10 01:02 PM, Susan Sohn wrote: > > On 02/15/10 18:48, Sanjay Nadkarni wrote: >> >> >> instantiate.c: >> Please use #if defined(sparc) > > ok > >> 224: Does create_disk_label have to be #ifdef'ed ? I understand >> that it is currently called only for sparc architectures but is there >> there anything in routine that is architecture specific and if so >> could you add a comment what that is. > > Not really. Will remove the ifdef. > >> 468 - 469: The comments for return values don't match what is being >> returned. (i.e NULL or not NULL) vs. 0, -1. Though this is not a >> result of your changes, could you please fix it. > > yes, will do. > > An updated webrev is at: http://cr.opensolaris.org/~sohn/14295b > > Thanks for the review, > Sue > >> On 02/15/10 03:22 PM, Susan Sohn wrote: >>> I'd like to get a review of my changes for: >>> >>> 14295 GPT labeled disks don't show up on SPARC with fix to bug 14144 >>> http://defect.opensolaris.org/bz/show_bug.cgi?id=14295 >>> >>> Webrev: >>> http://cr.opensolaris.org/~sohn/14295/ >>> >>> These changes implement the second part of the bug fix, to provide a >>> warning >>> popup to the user and to fix libti to recognize the GPT disk so that >>> an SMI >>> label can be applied. >>> >>> Thanks, >>> Sue >>> >>> >>> >>> _______________________________________________ >>> caiman-discuss mailing list >>> caiman-discuss at opensolaris.org >>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >> >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >
