Hi Sue, On Tue, 16 Feb 2010, Susan Sohn wrote:
> On 02/15/10 16:16, Alok Aggarwal wrote: >> >> On Mon, 15 Feb 2010, Susan Sohn wrote: >> >>> I'd like to get a review of my changes for: >>> >>> 14295 GPT labeled disks don't show up on SPARC with fix to bug 14144 >>> http://defect.opensolaris.org/bz/show_bug.cgi?id=14295 >>> >>> Webrev: >>> http://cr.opensolaris.org/~sohn/14295/ >>> >>> These changes implement the second part of the bug fix, to provide a >>> warning >>> popup to the user and to fix libti to recognize the GPT disk so that an >>> SMI >>> label can be applied. >> >> ti_dm.c: 1507: Could you please augument that comment >> to say DKIOCGGEOM is not supported on EFI disks? >> >> instantiate.c: line 220: The appropriate error code is >> returned in case of a failure and not -1. >> >> instantiate.c: lines 496 - 508: Could you please add >> a comment here indicating why the relabel is done only >> for SPARC? >> >> Looks good otherwise. >> >> Alok > > > Thanks for the review, Alok. > > Made requested changes and an updated webrev is at: > http://cr.opensolaris.org/~sohn/14295b Modulo Sanjay's comment about ENOTSUP for EFI disks, looks fine to me. Alok
