Hi Joe, I have a couple of general comments:
1) you said bug 15163 is used to track ALL the work that is needed for DC for the AI Image management project. Is the changes in this webrev all the changes that are needed? If not, does this mean that you will not push these changes even if the code review is approved? 2) Can you describe how you test these changes? Here are my comments about the code: ai_sparc_image.xml: ai_x86_image.xml: ---------------------------------- - What is "arg_name=" in the second line of the comments. I didn't see it mentioned else where. Do you mean all the 3 things in the "argslist"? - If the previous assumption is correct, I don't think it is a good idea to require people to specify arguments that they are not going to specify values for. The software should be made smart enough to not have that requirement. ai_publish_pkg: --------------------------- - lines 125-142: The cleanup() function does not remove the potentially partially populated repository. Should a non-complete repository be left around? - line 244-303: All these code makes the assumption that there are 8 arguments that will be passed in, and just references them. It would be important to check to make sure that there are actually 8 arguments that you can access before accessing any of them. - line 244-303: The "invalid_argument_found" variable is defined. I don't think it is necessary. Since any invalid argument will cause the program to exit. Why not exit immediately? Why waste time to do other computations? - line 251-267: I think all these code is not necessary because those values are not used for installation at all. - line 370: why is this statement inside $(), while all the other similar pkgsend commands don't have this? - line 389-391: Since this is a finalizer script, and not a normal user program, I don't think it is necessary to print this kind of information. People who decide to use this finalizer script should know how the repo can be used. Thanks, --Karen On 03/12/10 12:52 PM, Joseph J VLcek wrote: > Please review the fixes for: > > Bug 15163 - DC needs to be enhanced to publish the AI image as an IPS > repository > > The webrev is here: > http://cr.opensolaris.org/~joev/bug15163/ > > Bug 15163 will be used to track the work required to update the DC to > meet the needs of project "Automated Installation Service and Image > Management". > > I have tested these changes on x86 and will test on SPARC before pushing. > > I have developed the new finalizer script, ai_publish_pkg, in ksh. The > IPS command used by this script, pkgsend(1), does not have a direct > Python interface. However the IPS Transaction class could be used to > replicate what the pkgsend(1) command does allowing this script to be > implemented in Python. In discussing this with Dave Miner he wasn't > all that concerned that this script stay ksh. > > Thank you. > > Joe > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
