On 03/12/10 03:52 PM, Joseph J VLcek wrote: > Please review the fixes for: > > Bug 15163 - DC needs to be enhanced to publish the AI image as an IPS > repository > > The webrev is here: > http://cr.opensolaris.org/~joev/bug15163/ >
ai_publish_pkg: 232: Can we make the argument list optional? Since defaults all work, this should be possible. 327: Version should not be taken from the execution environment, it should come from the image being published. 345: Why wouldn't we default the publisher to opensolaris.org? 357: Is this actually necessary? Won't the checkpointing code have taken care of it? 370: I was surprised that this isn't encapsulated in an eval in order to get the transaction id into the environment; perhaps that's not necessary for file: FMRI's? However, I'd expect it's necessary to support http: FMRI's, which would be nice to allow, so does it break anything to have the transaction id? Obviously, if we do support http: FMRI's, then the comments in the manifests need updating. 389-391: Instructional output doesn't seem necessary Dave
