> Hi Alex, > > The change itself looks fine to me. > > I do wonder what happens if format(1M) ever changes > (another question > added, or some such thing). This section of code in > general (not your > fix specifically; but the original version as well as > the SMI labeling > just below the changed code) seems rather fragile. > > Thanks, > Keith > > On 03/12/10 04:00 AM, Alexander Eremin wrote: > > Please review the one line webrev at > > http://cr.opensolaris.org/~alhazred/15101/ > > which fix 15101 bug "idm_create_disk_label fails to > overwrite GPT with > > SMI label on some disks" > > Added additional 'no' to format call, which does > not affect cases where > > the question about geometry is not set. > > > > Thanks, > > > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-di > scuss > Well, caiman uses different system commands and they can change. I agree that it is not very strong. It seems the best option in the future - integrate in libti part of code for labeling from format.
Alexander -- This message posted from opensolaris.org
