Alex, Thanks for checking. That is most unfortunate.
John On 03/16/10 12:34 AM, Alexander Eremin wrote: >> Alex, >> >> It might be better to use format's command-file: >> >> From format(1): >> -f command-file Take command input from >> command-file >> rather than the >> standard input. The >> file must contain commands >> that appear >>> just as they would if >> they had been >>> entered from the >> keyboard. With this >> option, format does not >> issue continue? >>> prompts; there is no >> need to specify >> y(es) or n(o) answers in >> the command- >>> file. In non-interactive >> mode, format >> does not initially expect >> the input of >>> a disk selection number. >> The user must >>> specify the current >> working disk with >>> the -d disk-name option >> when format is >>> invoked, or specify >> disk and the disk >>> selection number in the >> command-file. >> >> This would resolve needing to update the code each >> time additional >> questions are added to format. >> >> Thanks, >> >> John >> >> On 03/15/10 08:57 AM, Keith Mitchell wrote: >>> Hi Alex, >>> >>> The change itself looks fine to me. >>> >>> I do wonder what happens if format(1M) ever changes >> (another question >>> added, or some such thing). This section of code in >> general (not your >>> fix specifically; but the original version as well >> as the SMI labeling >>> just below the changed code) seems rather fragile. >>> >>> Thanks, >>> Keith >>> >>> On 03/12/10 04:00 AM, Alexander Eremin wrote: >>>> Please review the one line webrev at >>>> http://cr.opensolaris.org/~alhazred/15101/ >>>> which fix 15101 bug "idm_create_disk_label fails >> to overwrite GPT with >>>> SMI label on some disks" >>>> Added additional 'no' to format call, which does >> not affect cases where >>>> the question about geometry is not set. >>>> >>>> Thanks, >>> _______________________________________________ >>> caiman-discuss mailing list >>> caiman-discuss at opensolaris.org >>> >> http://mail.opensolaris.org/mailman/listinfo/caiman-di >> scuss >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-di >> scuss >> > > So I rechecked this. This does not work for drives that have EFI label. Still > need to run the command: > "format -e -f format.cmd" where format.cmd must be: > label > n > n > q > > -- > Regards, > Alexander
