Hi Dave, thank you very much for your comments. Please see my response in line.
Jan On 03/18/10 11:08 PM, Dave Miner wrote: > Hi Jan, > > Looks generally good, a few small things. > > If configuring multiple user accounts turns out to be required, how > would this be accommodated? Multiple user_account_xx property groups? To be honest, I initially haven't thought about this possibility, but it could be addressed as you propose. The only issue I could see is that for additional user accounts we would not be able to take advantage of fix for bug 6934233. Fix for that bug will allow to omit specifying property types in SMF profile (and thus in System Configuration manifest) for those SMF properties which type is defined in SMF manifest. > > What about providing for an alternate path to the user's home directory? I was not sure if there is a need for this and if there might be a potential issue when we would like to provide user with mechanism to specify name of ZFS dataset, since home dir is to be created on shared ZFS dataset and name of target root pool might not be known at the time System Configuration manifest is constructed. If we would like to allow the user only to customize ZFS mountpoint of <root_pool>/export/home/<login> ZFS dataset, I think that should be fine. If not specified or set to '' (e.g. in SC portion in default AI manifest), it would expand to /export/home/<login> as it does today. Do you think it could cover the user's needs or there might be also need to customize name of ZFS dataset ? > > The manifest path in 11 should be updated per EMI path > recommendations, shouldn't it? Yes, you are right. The target directory should be /etc/var/manifest/. Thank you for catching this. > > Not sure why filesystem/minimal would be a dependency of your service? The intent here is to make sure that filesystems we need (/usr in case it would end up on separate dataset) are mounted. Inspecting more the dependency tree, being dependent on 'filesystem/minimal' is unnecessary restrictive, looking at svc:/system/filesystem/root:default, it should provide us with what we need. Thank you for pointing this out.
