> Hi Alex, > > The boot_archive_archive.py file can be traced back > to > bootroot_archive.py, which has an original copyright > date in slim_source > of 2008 . So, please change the copyright to: > > # Copyright (c) 2008, 2010, Oracle and/or its > affiliates. All rights reserved. > > Where does the number "5 partitions" for x86 come in? > If we're counting > just primaries, it would be 4. If we're counting > logicals + primaries, > that would be 4 + 36 = 40 partitions. > > Additionally, since you're "nearby," please change > line 222 from "is not > 0" to " != 0 ". (Doing a numerical comparison using > "is" has the > potential for some odd bugs down the line). > > Thanks, > Keith > > On 04/12/10 05:42 AM, Alexander Eremin wrote: > > Please review the fixes for: > > 15073 Automated Installer reports that system is > out of inodes and fails > > to proceed with install > > > > Bug: > > > http://defect.opensolaris.org/bz/show_bug.cgi?id=15073 > > > > Webrev: > > http://cr.opensolaris.org/~alhazred/15073/ > > > > New BA with inode overhead: > > sparc AI: > > nbpi = 8192 > > Filesystem size used avail capacity > Mounted on > /devpool/dc/build_data/pkg_image/platform/sun4u/boot_ > rchive > > 166M 128M 39M 77% > /mnt > x86 AI: > nbpi = 2048 > /rpool/dc/build_data/pkg_image/platform/i86pc/boot_ar > hive > > 111M 98M 14M 88% /mnt > > > > amd64 AI: > > nbpi = 4096 > > > /rpool/dc/build_data/pkg_image/platform/i86pc/amd64/bo > ot_archive > > 158M 134M 24M 85% > /mnt > > > x86 LiveCD (successfully booted and installed in > VBox with Base Memory = 512 MB) > > nbpi = 2048 > > > /rpool/dc/build_data/pkg_image/platform/i86pc/boot_arc > hive > > 136M 120M 16M 88% > /mnt > amd64 LiveCD > nbpi = 4096 > /rpool/dc/build_data/pkg_image/platform/i86pc/amd64/b > ot_archive > > 171M 158M 12M 93% > /mnt > > > -- > > Thanks, > > Alex > > _______________________________________________ > > caiman-discuss mailing list > > [email protected] > > > http://mail.opensolaris.org/mailman/listinfo/caiman-di > scuss > > > > _______________________________________________ > caiman-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/caiman-di > scuss > Hi Keith! Thanks for review, I made changes. Webrev is updated.
Cheers, Alex -- This message posted from opensolaris.org _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
