On 04/13/10 12:21, [email protected] wrote:
Hello,
This webrev is my proposed fix to the following installadm bugs:
7481 Remove use of site-specific option, GrubMenu, from AI setup
15531 installadm build_136 creates bad macro for X86 service
15593 create-client: needs to quote dhtadm macro strings again
In testing, I found the following and propose to fix it too, supplying
doctests to document and test the run_cmd() API:
15588 installadm_common: run_cmd() should raise OSError if
non-existent
command is attempted
Webrev:
http://cr.opensolaris.org/~clayb/15531/
Hi Clay,
I only looked at installadm_common.py so far, and I want to comment on
the run_cmd() function.
Very very similar functionality already exists in
usr/src/lib/install_utils/install_utils.py,
exec_cmd_outputs_to_log() function. Can we somehow just have 1 function
that
does the same thing?
Thanks,
--Karen
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
