> Alex, > > Looking at the code in > usr/src/cmd/distro_const/utils/boot_archive_configure > is there any concern about creating the file and then > doing the chown? > > 355 echo $VOLSETID> $VOLSETID_FILENAME > > 356 $CHMOD 0444 $VOLSETID_FILENAME > > 357 $CHOWN root:root $VOLSETID_FILENAME > > > > This can be changed to temporarily set the umask, > create the file and > then reset the umask to what it was (not tested): > > oumask=`umask` > umask 0222 > echo $VOLSETID > $VOLSETID_FILENAME > umask $oumask > $CHOWN root:root $VOLSETID_FILENAME > here is no concern (probably due to use case) then > the changes look > fine to me. > > Thanks, > > John > > > On 04/19/10 06:17 AM, Alexander Eremin wrote: > > Please review the fixes for: > > 15571 long volume IDs break x86 ISO image builds if > customized grub menu > > is long > > > > Bug: > > > http://defect.opensolaris.org/bz/show_bug.cgi?id=15571 > > > > Webrev: > > http://cr.opensolaris.org/~alhazred/15571/ > > > > _______________________________________________ > caiman-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/caiman-di > scuss >
Hi John, thanks for review. I changed these lines according to the previous volumeid creation, in this case we should probably define umask as $UMASK before, also chmod is used in this way further in this script and I I would prefer to keep the old method ) Cheers, Alex -- This message posted from opensolaris.org _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
