> On 04/19/10 06:17, Alexander Eremin wrote: > > Please review the fixes for: > > 15571 long volume IDs break x86 ISO image builds if > customized grub menu > > is long > > > > Bug: > > > http://defect.opensolaris.org/bz/show_bug.cgi?id=15571 > > > > Webrev: > > http://cr.opensolaris.org/~alhazred/15571/ > > > > Hi Alex, > > Thank you for working on this bug. > > You need to update the "distribution name" value for > usr/src/cmd/distro_const/slim_cd/all_lang_slim_cd_x86. > xml. That's the > manifest > for the Live CD image that includes all the > languages. The distribution > name > there currently shows "OpenSolaris". > > I want to clarify one thing. From reading the code, > the volume id will now > just be whatever string we specified for > "distribution name" in the > manifest. > It will not be appended with snv_xxx, right? I want > to make sure that's > the case, because in your email interchange with Alan > Steinberg, you > keep using the example of: > > OpenSolaris_X86_snv_134 > OpenSolaris_AI_X86_snv_134 > OpenSolaris_Text_X86_snv_134 > > In this case, in order to get those strings as the > volume id, we would have > to specify the build number ourselves, right? > > Thanks, > > --Karen > > _______________________________________________ > caiman-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/caiman-di > scuss >
Hi Karen, thanks for point about "all_lang_slim_cd_x86", I'll fix this. Alan told about volumeids which DC generates at this time. I used the build number for identification in 13276 fix, now as the UUID is used for the identification, I am not sure that the build number must be used with the distro_name for volumeid (it may be appear in the Grub title?). Otherwise, need to somehow indicate to the user that the volumeid will consist of the distro_name + build number, and length should be no more than 32 characters. This time build number can be used with default distro names in manifests but every time if the user decides to change the distro name, he will have to calculate the volumeid length. I can revert to this, but experience has shown that it confuses users. What you think? Thanks, Alex -- This message posted from opensolaris.org _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
