Jack,
Looks good.
The following from auto_install.c:
2033 if (access(INSTALLED_ROOT_DIR, F_OK) == 0) {
2034 if (ls_transfer("/", INSTALLED_ROOT_DIR) != LS_E_SUCCESS) {
2035 auto_log_print(gettext(
2036 "Could not transfer log file to the
target\n"));
2037 }
2038 }
Could be written as:
if (access(INSTALLED_ROOT_DIR, F_OK) == 0 &&
ls_transfer("/", INSTALLED_ROOT_DIR) != LS_E_SUCCESS) {
auto_log_print(gettext(
"Could not transfer log file to the
target\n"));
}
Though not critical.
John
On 06/ 8/10 03:20 PM, Jack Schwartz wrote:
Hi everyone.
Here is a fast code review of a couple of small issues which
Driver-Update caused to appear:
16088 <http://defect.opensolaris.org/bz/show_bug.cgi?id=16088> DDU AI install
did not copy install_log to system if DDU install fails.
16097 <http://defect.opensolaris.org/bz/show_bug.cgi?id=16097> AI Driver
Update gives misleading messages about finding and not-finding packages
Please review:
http://cr.opensolaris.org/~schwartz/100608.1/webrev/index.html
Thanks,
Jack
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
