On 06/10/10 10:04, Jack Schwartz wrote:
Hi Ethan.
On 06/ 8/10 05:41 PM, Ethan Quach wrote:
On 06/08/10 15:20, Jack Schwartz wrote:
Hi everyone.
Here is a fast code review of a couple of small issues which
Driver-Update caused to appear:
16088 <http://defect.opensolaris.org/bz/show_bug.cgi?id=16088> DDU AI install
did not copy install_log to system if DDU install fails.
The synopsis of the bug doesn't do it justice (or perhaps there's
some other bug filed which encapsulates this that I'm not finding),
but it seems to me the more critical aspect of this is that install
failed at all. As per the first sentence in the description:
"This is found when I tested osol_140 after DDU integrates. I used the
following default xml that will do a searchall and DDU install fails."
What is being done to address that? Can I suggest that until that
issue is resolved that we remove /searchall from the default manifest,
and do that with this putback
Background:
-----------
That the auto-install fails if the DDU fails to install a needed
package was done by design. The assumption was that a needed
uninstallable package could be critical to the system being able to
boot, and the sysadmin should check the system before rebooting.
One could also make the assumption that the likelihood of a system not
being able to boot due to something going wrong during Driver Update
is small. This is because most of the time disk or other critical
drivers won't be installed during Driver Update. Under that
assumption, we can have AI succeed and reboot when the DDU fails, at
least in some cases.
There is also the issue you brought up that it is important that AI
succeed in the default manifest scenario. This includes, potentially,
when the DDU fails.
How to fix:
-----------
You and I talked about changing when the DDU would cause AI to fail.
One possibility is:
- Fail AI whenever the DDU fails to install a driver package that is
explicitly specified in the manifest, for any reason.
- Fail AI whenever the DDU fails to install a driver found during
<searchall>, for reasons OTHER than the package is not found.
- Succeed AI whenever the DDU fails to install a driver found during
<searchall> because the package is not found.
The first two items are failures either due to user error or an
uncommon problem with the system. The last item would have AI succeed
if the problem is the lack of a package, which could be a more common
occurrence.
Still, some users will *want* their install to fail when the DDU fails
for *any* reason, as is the current case. In order to provide a
solution that works for all, I propose introducing a new attribute to
the <searchall> tag:
<searchall pkg_not_found="ok">
<searchall pkg_not_found="error">
The default would be pkg_not_found="ok".
A nit, but instead of "pkg_not_found", how about "driver_not_found"
since it seems like what we're searching for are drivers for devices,
they just happen to be delivered via packages.
Also another nit, instead of "ok", perhaps "ignore"?
Overall I am in support of this change.
thanks,
-ethan
In the meantime:
----------------
I can remove the <searchall> tag from the manifest temporarily, until
the above is implemented. I can do this immediately with this
putback. The DDU team and I will get to making the fixes probably
within the next couple of builds.
Please send any comments/protests regarding removing <searchall>
ASAP. Please send other comments/questions/suggestions before Monday
6/14 COB.
Thanks,
Jack
-ethan
16097 <http://defect.opensolaris.org/bz/show_bug.cgi?id=16097> AI Driver
Update gives misleading messages about finding and not-finding packages
Please review:
http://cr.opensolaris.org/~schwartz/100608.1/webrev/index.html
Thanks,
Jack
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
