Thanks for the review sarah.
Comments inline below.
On 06/16/10 03:30 PM, Sarah Jelinek wrote:
Hi Matt,
Apologies for the delay in getting back to you on this. I did not
review others comments so I may be repeating theirs. I didn't review
them because I wanted to look at this fresh without any other input.
If I do repeat things please just point me to the email where you have
answered their questions.
Comments/questions:
-So, with the desire to have the new schema elements and attributes
sooner in AI, we should consider not modifying liborchestrator to
handle the new discovery. I would like you to consider using the
target discovery and target instantiation modules that Jean is working
on. I realize this may not align with your work, so if it doesn't
that's fine. Just something I would like you to follow up on.
Agreed this would make sense, as any code in liborchestrator is
potential throw away code. I have a look at the work Jean is doing and
see if it makes sense try and use it for this project.
-To keep this work in alignment with the new schema, I am proposing
the names of some of your elements and attributes be changed.
Specifically:
zpool_properties->pool_options
zpool_file_system_properties->dataset_options
zpool_vdev->vdev
zpool_dataset->dataset
root->is_root(this is an attribute)
Done
I would also suggest creating the hierarchy for the dataset types, and
then using this, even if a subset for defining what we are creating in
the zpool. So, my suggestion is:
element: dataset-comprised of:
zvol, filesystem, snapshot-one or more of each of these
So are you saying that providing optional sub elements inside <dataset>
which define the type of dataset ?
As of current document (not posted yet), I am including a type attribute
on the <dataset> element which identifies the dataset type, currently
only two types being supported "filesystem" or "zvol"
Also, you might consider changing some of the existing schema element
and attribute names. specifically:
ai_target_device->target_device
ai_device_partitioning->partition
ai_device_vtoc_slices->slice
ai_swap_device->swap
ai_dump_device->dump
Done
attributes on the elements, in order, should be:
Not sure what you mean here ?
thanks,
sarah
*****
On 06/ 4/10 09:50 AM, Matt Keenan wrote:
Hi,
First draft of the Automated Installer Multi Disk/Pool Support Design
v0.1 is now available for review at :
https://securewiki.sun.com/download/attachments/78512557/ai-multi-design-0.1.pdf
Regards
Matt
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
