On 06/24/10 05:15, Matt Keenan wrote:
Hi,

Thanks for the feedback/review, I've incorporated changes back into the design document and a 2nd draft of Automated Installer Multi Disk/Pool support design is now available
for review :

Version 0.2  :
http://hub.opensolaris.org/bin/download/Project+caiman/auto_install/ai%2Dmulti%2Ddesign%2D0.2.pdf


Cheers

Matt
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Hi Matt,

2.1 lib/libtarget_pymod section is listed twice

2.2.1
o <iscsi_target_paramaters> -> <iscsi_target_parameters>

o <target_device_type> / <target_device_vendor> / <target_device_sizeice>
 target_device_sizeice -> target_device_size

o "Can only specify one <ai_target_device> element."

If more than one ai_target_device is specified in the manifest, is the manifest considered invalid? This should be indicated in the doc.

o "If not specified in AI manifest, default is to select current boot disk, otherwise the first disk with sufficient size for install is chosen."

Back during some earlier AI client design work, I believe that Frank said that if no disk selection specification had been made in the manifest, then the manifest should be considered invalid. This may have changed, but would be good to check with him if you haven't already.

If it is decided to leave this as is, how is the "first disk" determined? Will this provide repeatable behavior (i.e., will the same disk always be chosen in this situation)?

o if multiple disks meet the device specification (e.g., multiple disks meet target_device_size or target_device_vendor), how is it determined which disk to use?

2.2.4 has been down -> has been done

3.2.1.1
2nd bullet: Optional Attribute "root"
I think this should be "is_root" to match what is in Appendix 1.
5th bullet: property-value -> property=value
6th bullet: target/slice/patition -> target/slice/partition

3.2.1.3 The second ai_device_vtoc_slices should be ai_device_vtoc_slice_contents

3.2 You mentioned libtarget_pymod and libti_pymod in section 2.1, but though you expand here on the other consumers mentioned there, such as libti and liborchestrator, don't see anything else about libtarget_pymod or libti_pymod. Should they be included in this section too?

Thanks,
Sue
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to