Alok,
On 06/24/10 01:51, Alok Aggarwal wrote:
Hi Dermot,
Overall looks pretty good.
Section 3.4.1.1 - What would be the format/contents
of the dtd_file here? Would they be helper methods
or something else?
It's the normal DTD schema for the manifest. The DTD file
can be specified either by being directly referenced in the headers
of the manifest (which we usually do) or as a separate, stand-alone,
file by using this param.
Section 3.4.1.2 - It seems that some of the applications
that register ManifestParser (DC in particular) won't know
if the manifest provided by the user contains a DTD reference
or not. So, I think counting on the application to do the
right thing may be a stretch especially since a ManifestError gets
raised any way in this case.
Yes - Keith made a similar point and suggested an alternative
that I plan to go with: the default behavior will be "if the manifest
references a DTD, then use it, otherwise don't validate" but I'll still
allow the other params to override this.
Page 13: I asked about this privately but makes sense to
ask here too - where will the implementation for the
DataObject sub-classes that handle, say, configuration schema
come from?
They're not strictly part of the spec of ManifestParser, but I will add
a reference to those classes somewhere in the doc.
Thanks,
- Dermot
Thanks,
Alok
On Thu, 17 Jun 2010, Dermot McCluskey wrote:
Hi,
I hope there is still some enthusiasm left for reviewing design specs?
I'd like to request a review for my design for ManifestParser and
ManifestWriter.
The latest version of the document can be found here:
http://hub.opensolaris.org/bin/preview/Project+caiman/OpenSolarisInstaller+-+ManifestParser+and+ManifestWriter
As this component is slightly less complex than others that have
recently been
reviewed, I'd like to request that comments be sent by Friday June
25th. If this
is not practical, I will extend this date.
Please let me know if you intend to review this so I can be sure I
have enough
reviewers. I would particularly appreciate comments from some of the
following:
Jack, Alok, Karen, Darren, Sarah.
Thanks,
- Dermot
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
