Hi Dermot,
Besides the my comments in the meeting discussion, I have the following
comments/questions.
- Section 1.1:
Another feature that's provided by Jack's ManifestRead implementation
is the ability to *compute* defaults dynamically and perform semantic
validation.
I understand the new ManifestParser/ManifestWriter will not
provide these 2 features. I think it is worth noting this difference in
section 1.1.
Current implementation of DC is utilizing those 2 features. By noting it
here, the updated DC implementation will know to add those functionalities
in the DC code.
- For both the ManifestParser and ManifestWriter checkpoints,
path of files provided in the constructor are not validated
until execute(). Is there a reason why this is better?
IMO, it is better to validate and fail asap....
- The cancel() method is not mentioned in ManifestParser
and ManifestWriter sections. I know you discussed it
in the slides, perhaps you want to add it to the document too?
Thanks,
--Karen
On 06/17/10 06:02 AM, Dermot McCluskey wrote:
Hi,
I hope there is still some enthusiasm left for reviewing design specs?
I'd like to request a review for my design for ManifestParser and
ManifestWriter.
The latest version of the document can be found here:
http://hub.opensolaris.org/bin/preview/Project+caiman/OpenSolarisInstaller+-+ManifestParser+and+ManifestWriter
As this component is slightly less complex than others that have
recently been
reviewed, I'd like to request that comments be sent by Friday June
25th. If this
is not practical, I will extend this date.
Please let me know if you intend to review this so I can be sure I
have enough
reviewers. I would particularly appreciate comments from some of the
following:
Jack, Alok, Karen, Darren, Sarah.
Thanks,
- Dermot
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
