Hi Keith,
The updated webrev looks good to me.
Please file a low priority bug to for the issue I brought up,
but you don't have time to fix now.
That way, when somebody touches that code, they can
just fix it easily.
Thanks,
--Karen
On 06/29/10 03:21 PM, Keith Mitchell wrote:
On 06/29/10 02:24 PM, Karen Tung wrote:
Hi Keith,
For both places where we split the mount command into lofiadm+mount,
I think it would be useful to put a comment there talking about why
we have to
do it that way.
Per your, Sue, and Evan's suggestion I've added comments explaining
the reasoning.
In net-fs-root, line 254, should we add the option "-o ro" for this
call?
I know it is not there in the previous version, but I thought we will
make it consistent with the mounting of solaris.zlib above, and also
consistent with the mounting of solarismisc.zlib in media-fs-root.
Given the timing and severity of these bugs, and the turnaround to
build and test an image, I'd rather limit my fixes to exactly what's
required. I can file a separate bug against this line if needed.
In media-fs-root, line 124 and line 137, I think it will good to
check the
string returned by the "lofiadm" like it is done in the net-fs-root
script.
Done.
Updated webrev in place:
http://cr.opensolaris.org/~kemitche/16400/
Thanks,
Keith
Thanks,
--Karen
On 06/29/10 01:58 PM, Keith Mitchell wrote:
While verifying the fix for bug 16400, I discovered/confirmed and
filed bug 16411 (which Jan had noticed earlier).
I've added my proposed fix for that bug to my webrev for 16400 and
16408. The affected files are media-fs-root and net-fs-root. I would
appreciate a review of the suggested fix ASAP so that I can deliver
the fixes for all 3 bugs.
The webrev has been updated in place with my proposed fix:
http://cr.opensolaris.org/~kemitche/16400/
Verification done:
Jan had previously verified that the proposed fix would work for
network AI. I've confirmed that it fixes bootable AI and will
doublecheck liveCD and text install images once they're done building.
Thanks,
Keith
On 06/29/10 10:54 AM, Keith Mitchell wrote:
Hi all,
I need a code review for my fix for bugs 16400 and 16408
https://defect.opensolaris.org/bz/show_bug.cgi?id=16400
https://defect.opensolaris.org/bz/show_bug.cgi?id=16408
Webrev:
http://cr.opensolaris.org/~kemitche/16400/
Details of 16400:
Added timeout_seconds attribute to all "exec_method" elements. As
all of our custom exec_methods exec ":true", I set the timeouts to
0. It's been suggested that perhaps the timeout should match the
"real" service; that seems to me like extra work (and maintenance,
if those values ever change in the "real" service - would they need
to be updated here?), but I can change the values easily enough if
there's concern.
I also removed the xmlns:xi portion from all *live.xml files, as
the DTD validation was having problems with those and they served
no apparent purpose.
Verification:
Used lxml.etree and pointed at the latest service_bundle.dtd.1 file
from the onnv-gate to verify that our live.xml files pass
validation. Additionally, I'm running DC builds of liveCD, text
installer, and AI, and so far they've all passed the ba-config
step, which is where the validation would occur. I will also ensure
that each image boots properly before pushing.
Details of 16408:
The install-incorporation manifest in slim_source needs to match
what was previously handled by RE and the importer; which means the
obsolete/renamed packages need to be included, as well as some
additional packages that are tagged under install-incorporation
(such as python/lxml). As a short term fix, I've explicitly added
them to the manifest file; long term it would be more consistent
for our gate to build the empty, renamed packages (to catch the
cases of upgrading from a built copy of our gate, and for tracking
purpose) - but for expediency's sake I'd like to defer that and
lump it with changes to our gate to fully remove the SVR4 packages.
Verification:
Built the gate; ran a depot out of the built packages and confirmed
that the install-incorporation has all expected packages constrained.
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
