On 07/19/10 01:58 PM, Jack Schwartz wrote:
On 07/19/10 06:17 AM, [email protected] wrote:
On 07/16/10 09:19 PM, Jack Schwartz wrote:
Hi everyone.
be_run_cmd has been simplified per all of the feedback received.
Please bless.
Revised webrev, same location:
http://cr.opensolaris.org/~schwartz/100710.1/webrev/
Delta:
http://cr.opensolaris.org/~schwartz/100710.1/webrev.3.4.diff
Thanks,
Jack
<snip>
Hey Jack,
This looks good.
One question though.
Do you think it would be valuable to do some validation on the input
arguments to be_run_cmd?
Maybe check the buf pointers against NULL and the bufsizes against
non-positive ints. What do you think?
I think it is good enough that the comments state what is and isn't
allowed as far as parameters (including that a NULL stderr buffer is
not allowed). Bad parameters passed to be_run_cmd() are programming
errors, and will never come based on an end-user input. As such, I
don't think it is helpful to do such checking.
Thanks,
Jack
Other than that you have my blessing! ;)
Joe
Since, as we discussed off-line, be_run_cmd is an internal interface
I'm OK with it.
Joe
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
