* Jack Schwartz ([email protected]) wrote: > Hi everyone. > > Based on last week's gyrations I trimmed all unnecessary fat from > this function. This added check seems like unnecessary fat to me as > this function is internal. > > But I want this code review to be done, so I will make the following > change, which is in the spirit of what is proposed. > > if ((command == NULL) || (stderr_buf == NULL) || (stderr_bufsize<= 0) || > (stdout_bufsize< 0) || ((stdout_buf != NULL) ^ (stdout_bufsize != 0))) { > return (BE_ERR_INVAL); > } > > > Note the second line is what it is because stdout_buf can indeed be > passed as NULL.
Looks fine to me. Thanks Jack! Glenn _______________________________________________ caiman-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
