On 07/13/10 03:50 PM, Glenn Lagasse wrote:
[I apologize for anyone that recieves this in duplicate, it was pointed
out to me that my mailer had munged the CC list and so people that were
meant to be copied, weren't]

The ON SNAP Integration project is ready for a code review.  Since we're
moving existing code in slim_source into ON I've tried to make things a
little easier to review.

I have two webrevs/workspaces for review.  The first workspace is based
on slim_source and is sync'ed with Jack's latest changes that he's
already got a review out for.  This workspace has the file differences
for the existing files that are moving from slim_source into ON.  This
workspace should be used to review only files that aren't "new"
as part of the integration into ON*.  That list of files is:

The webrev for this is:

http://cr.opensolaris.org/~glagasse/hg_beadm_1_noinstallgrub/


http://cr.opensolaris.org/~glagasse/onnv-clone

I only took a quick glance through the packaging changes.

install-beadm.mf
  l30 should be deleted, per
      http://onnv.sfbay.sun.com/flagdays/pages/20100614015030.html

  Please run pkgfmt over this manifest before integrating it.

SUNWbeadm.mf
  l28 same as above

You also seem to be moving libbe.so from system/library/install to install/beadm and changing it at the same time as doing a cross-consolidation move. That's a bit exciting since both packages will own the file for developers for a little while. I would have tried to avoid moving and changing files at the same time. So, please make sure your testing of an ON update without a corresponding Install update goes well.

liane
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to