On 07/26/10 10:39 AM, Jan Damborsky wrote:
Hey Joe,
thank you very much for review - please
see my response below.
Jan
On 07/26/10 03:48 PM, [email protected] wrote:
On 07/26/10 09:26 AM, Jan Damborsky wrote:
Hi Ethan,
could I please ask you for reviewing the changes for following bugs ?
7850 RFE would like support for static network instead of nwam config
10781 RFE - AI Needs to Support DNS Name Service Configuration for
Clients
webrev:
http://cr.opensolaris.org/~dambi/bug-7850/
Related ON CRs:
6923163 Automated Install requires mechanism for configuring static
IP addresses
6923168 Automated Install requires a mechanism for configuring name
services for clients
The install portion of changes is merely about enhancing default
AI manifest (SC portion) with template specifying configuration
of new smf services allowing configuration of static IP and DNS.
Thank you,
Jan
Tested scenarios:
* scenario 1 - parameters configured:
- one interface with static IPv4
- IPv4 default route
- one interface with static IPv6
- IPv6 default route
- configure DNS
* scenario 2 - parameters configured:
- one interface with IPv4 obtained from DHCP
- one interface with IPv6 - use autoconfiguration
- configure DNS
* scenario 3 - NWAM takes care of network configuration
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
Hey Jan,
I have 2 issues/questions.
Issue #1: Total nit: After some of the values you have a blank space
between the ending ' and the trailing "/>" but not for all of them.
Perhaps removing this space would be good.
I agree - I removed those spaces and updated
the webrev:
http://cr.opensolaris.org/~dambi/bug-7850-cr/
Issue #2: A question(s): Wouldn't it be best to have the default case
be NWAM?
Actually, NWAM is the default case - following section takes care of it:
<service name="network/physical" version="1" type="service">
<instance name="nwam" enabled="true"/>
<instance name="default" enabled="false"/>
</service>
Also, new install configuration services are disabled by default.
If so shouldn't the static settings be commented out by default?
In general, appropriate comment sections should be added to the default
SC manifest to describe and separate particular configuration areas.
However, we can't do this right now, since SC manifest is currently
embedded as XML comment within AI manifest and XML does not
allow nested comments.
Once Schema/manifest rework is done, the plan is to enhance default SC
manifest with comment sections in similar way it is done in DC manifests.
Great!
Thank you for explaining. Yes comments would be helpful, once they are
possible.
Looks OK to me now.
Joe
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
