Hi Jack,
Looks good, and a lot better than the previous way of reading the file :)
A couple of small questions, just for confirmation:
- What happens if the file doesn't exist - with the cat it would result in
nothing to loop over, but the script execution would continue - in this case
does it impact the execution of the script?
- Lines 84-86
- Is this really necessary to do? I believe that ln will do this itself if the
file is a directory - but maybe there is a reason it was written this way
originally?
Thanks,
Darren.
On 07/28/10 11:41 PM, Jack Schwartz wrote:
> Hi everyone.
>
> Here is a webrev of a fix for:
> 6971381 <http://monaco.sfbay.sun.com/detail.jsf?cr=6971381> DC needs to
> better
> account for spaces in filenames when creating /mnt/misc symlinks
>
> Code changes are in boot_archive_configure:
> - changes how a list of files is read so the filenames are not split apart,
> - envelopes the variable representing a filename with quotes so the shell
> doesn't split the filename apart as it builds a commandline with it.
>
> --> Lines of code is barely into double-digits.<--
>
> Please review by Friday COB.
>
> http://cr.opensolaris.org/~schwartz/100726.1/webrev/
>
> Testing done with live images built: X86 live CD, text and AI; SPARC: text
> and AI
>
> Thanks,
> Jack
>
>
>
> _______________________________________________
> caiman-discuss mailing list
> [email protected]
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
