Hi Jack,
On 07/29/10 11:13 PM, Jack Schwartz wrote:
> Hi Darren.
>
> Thanks so much for reviewing...
>
> On 07/29/10 12:17 AM, Darren Kenny wrote:
>> Hi Jack,
>>
>> Looks good, and a lot better than the previous way of reading the file :)
>>
>> A couple of small questions, just for confirmation:
>>
>> - What happens if the file doesn't exist - with the cat it would result in
>> nothing to loop over, but the script execution would continue - in this
>> case
>> does it impact the execution of the script?
>>
> This shouldn't be an issue. The file in question is ${TMP_DIR}/mlst.
> create_sym_links() is called in only one place (from the bottom of the
> same module), right after mlst is created. mlst is created with
> contents from /etc and /var, and so will never be empty. (System won't
> boot with certain /etc files missing.)
OK.
>> - Lines 84-86
>>
>> - Is this really necessary to do? I believe that ln will do this itself
>> if the
>> file is a directory - but maybe there is a reason it was written this
>> way
>> originally?
>>
> This (or something like it) has been there from the beginning* and I
> don't feel comfortable removing it.
>
> I only changed the variable processed by that line because that variable
> was not really needed.
>
> * Search for "p=$p" in bugzilla bug 835, for example.
>
Understood, just asking out of curiosity more than anything...
+1 from me.
Thanks,
Darren.
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
