Hi Clay,
You have addressed all my initial code review comments. A few questions,
and one request:
installadm-common.sh
1088 line=`$GREP "^${IMAGE_BOOTDIR}[ ]"
/etc/vfstab`
Why do we need to do this again when we have done it at line 1086. The
difference is we haven't assigned the value to 'line' but I am not sure
whey we have this two times.
setup-tftp-links.sh:
62 elif [[ "$TYPE" == "server" ]]; then
63 if (( $#< 5 )); then
64 exit 1
65 fi
66 IMAGE_PATH=$3
67 DHCP_CLIENT_ID=$4
68 BARGLIST=$5
Should you be checking for < 4, not < 5 here? Is bootargs required?
Could you please file a bug for ai_sd.py to return less mysterious
values in an error condition?
thanks,
sarah
****
On 07/30/10 05:18 AM, [email protected] wrote:
Hi all,
If you have provided me feedback on the AI Multi-homed feature
code, could you please ensure your desired changes have been affected?
I would ideally like a go/no-go by COB Monday 8/2.
Also, for everyone's information, it was requested that I add a
feature to allow a multi-homed server to masquerade as a single-homed
server. This allows support for older multi-homed unaware images to be
served on a multi-homed server with only some loss of multi-homed
functionality. Lastly, a number of QE found bugs have been addressed
as well.
Full webrev:
http://cr.opensolaris.org/~clayb/webrev_multihomed//final_full/
Differential from initial webrev:
http://cr.opensolaris.org/~clayb/webrev_multihomed//final_diff/
Original webrev:
http://cr.opensolaris.org/~clayb/webrev_multihomed/
Thank you,
Clay
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
