Hi Sarah,
Thank you for your catches!
Thank you,
Clay
On Mon, 2 Aug 2010, Sarah Jelinek wrote:
[snip...]
installadm-common.sh
1088 line=`$GREP "^${IMAGE_BOOTDIR}[ ]" /etc/vfstab`
Why do we need to do this again when we have done it at line 1086. The
difference is we haven't assigned the value to 'line' but I am not sure whey
we have this two times.
This was a turd from some testing I was doing; simplified as expected.
setup-tftp-links.sh:
62 elif [[ "$TYPE" == "server" ]]; then
63 if (( $#< 5 )); then
64 exit 1
65 fi
66 IMAGE_PATH=$3
67 DHCP_CLIENT_ID=$4
68 BARGLIST=$5
Should you be checking for < 4, not < 5 here? Is bootargs required?
I don't know why but the script is setup to expect an argument for bootargs;
however, if one wishes to not have bootargs one passes in "null". I've
confirmed this behavior is appropriately matched in the one caller of
setup-tftp-links with the server subcommand (installadm.c line 915).
Could you please file a bug for ai_sd.py to return less mysterious values in
an error condition?
Thank you for raising this, I've filed: 16730 - ai_sd.py uses mysterious return
codes
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
