Hi Jean,
software.dtd.html:
line 42: Capitalization comment from above.
lines 56-59: Sarah and I discussed just 2 days ago adding
<!ATTLIST image img_action (create|use_existing|update)>
here. You should ask her about this. This would make the
destination required in the schema for an image so it might have
bigger impact than you think.
This is something we discussed but I hadn't added it to this code
yet. This discussion happened after we froze the code for this review.
I am not sure that destination will be required with these changes.
I thought about this some more after we talked.
The img_action attribute is required in the new schema. If a user
specifies a create with no destination, then we can assume the
default destination. If a user specifies a use_existing or update
wtih no destination element then this would result in a failure.
This is part of the semantic validation we must do, either in the
client or in the import of the manifest.
If destination is not required, then of course img_action isn't
required, because the user doesn't have to specify an image.
I think this is also ok.. This is how I see the possible scenarios:
Assuming default is:
'create image at default location'
-User wants to use default action(create):
No destination specified. Default action is to create an image at the
default location.
-User wants to specify the image location. Use default action(create):
Destination is specified and action is to create a new image at this
location.
-user wants to use an existing image. Must specify img_action:
<image img_root="/export/home/foobar/image" img_action="use_existing">
This will result in clearing the image of all installed packages and
reinstalling the defined list. Does not re-create image.
-User wants to update an already created image, must specify img_action:
<img img_root="/export/home/foobar/image" img_action="update">
This will result in the addition of specified packages to this image.
this should work right, which makes destination and img_action optional.
The reason we had discussed making img_action required (and thus
destination) was that if we default to create and there happens to be
an image already in the destination then it would be destroyed. Which
leads to a question:
If the img_action is create and an image exists in the destination I
have 2 options:
1) remove the old image and create the new one.
2) raise an exception.
I think that we can publish the default behavior which is create at a
default location and if the user doesn't specify a destination and
corresponding image data then it is user error. The concern I have about
making destination required is that it makes the simple case less
simple. And is not required. We know what the default behavior is and we
shouldn't make the user tell us.
The safer route to me appears to be 2 and the caller needs to make
sure that destination is empty.
No, I don't think we should raise an exception. If the img_action is
create and it is in the location we either default to or the user
specifies then we consider it a new image.
thanks,
sarah
Opinion?
Jean
sarah
***
If the user specifies a destination with a 'create' action then we
just create the image at the location specified.
I will have to update the software.dtd to reflect the inclusion of
the img_action attribute.
sarah
****
Jean
On 08/ 5/10 04:07 PM, Ethan Quach wrote:
Hi all,
The following is the code review for the AI manifest schema changes,
and the installadm criteria changes. It is a rather large
review, so
partial/piecewise review would be also be fine, just let us know
what
you're reviewing. We've pre-requested reviews from some of you
already, but all comments welcomed by Aug 16th.
Webrev:
-------------
http://cr.opensolaris.org/~equach/webrev.ai-schema/
Bugs:
--------
16423 <http://defect.opensolaris.org/bz/show_bug.cgi?id=16423>
Updates to AI schema should be made
15449 <http://defect.opensolaris.org/bz/show_bug.cgi?id=15449>
installadm add validates combined manifest against image-specific
schema as well as schema in /usr/share/auto_install/
6975043 <http://bugs.opensolaris.org/view_bug.do?bug_id=6975043>
separate criteria and ai manifest
thanks,
-ethan
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
------------------------------------------------------------------------
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
