[...]

157: As I recall from some conversations with Sue, isn't one of the values for criteria a filename? If so, isn't the lower() call going to have an adverse affect for files that have capitals? I can understand calling "lower()" on all the keys at this stage, but lowercasing the values at this stage seems unnecessary.

No, values for criteria aren't filenames.  Perhaps you're thinking
about the -C option, which is a filename.

None of the criteria *now* are case-sensitive filenames - but can you guarantee that none of the values in the future will ever be case sensitive (files or otherwise)?

This will have to be addressed uniformly throughout then.
Many places in the code do a lower() and sometimes upper()
of the values as they're parsed in and spit out from the DB
storage.  If case-sensitivity is indeed a problem, it needs to
be addressed properly.

I will consult with Clay on this issue and file a bug as
necessary, but for now I'd like to leave that line alone.

Since it's a wider issue, I'm fine with leaving the new code as written.

- Keith



thanks,
-ethan


_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to