Hi Dave,
Responding to installadm man page comments...
On 08/13/10 07:22, Dave Miner wrote:
On 08/ 5/10 06:07 PM, Ethan Quach wrote:
Hi all,
The following is the code review for the AI manifest schema changes,
and the installadm criteria changes. It is a rather large review, so
partial/piecewise review would be also be fine, just let us know what
you're reviewing. We've pre-requested reviews from some of you
already, but all comments welcomed by Aug 16th.
Webrev:
-------------
http://cr.opensolaris.org/~equach/webrev.ai-schema/
A couple of other comments:
Manifests (default.xml, ai_manifest.xml):
- Why is the default manifest set to enable auto-rebooting? This isn't
necessarily safe on x86 since we can't control the boot order, so that's
why it was disabled in the existing default. I'd agree with placing it
in the sample ai_manifest.xml with an appropriate comment noting this
issue.
- It would be good to grab my updated comments in the 6973927 wad's
manifests around the install/uninstall tags and merge them into the new
manifest. You will also be able to safely remove SUNWcsd and SUNWcs
references as soon as that integrates.
- Default manifest shouldn't reference internal publishers
installadm.1m.txt
326, 334: s/should not/must not/
will change
373: really more a design issue, but the lack of a way to remove
criteria is striking in this context. Probably file an RFE so we think
about this some more.
I agree, that might be a nice thing to have. There is the workaround of
re-specifying the criteria (minus the one(s) you want to remove) with -c/-C, but
direct removal is something to consider. Will file an rfe.
654: s/MG/MB/
indeed
662: The specifics of the file don't actually matter for the example. On
the other hand, nowhere in the man page have we documented the content
for the criteria file. Perhaps add a section on that, and then this
example could just reference the section.
I'll do that.
Thanks for the review,
Sue
Dave
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
