Sarah Jelinek wrote:
On 08/12/10 09:20 AM, Dave Miner wrote:
On 08/ 5/10 06:07 PM, Ethan Quach wrote:
Hi all,
The following is the code review for the AI manifest schema changes,
and the installadm criteria changes. It is a rather large review, so
partial/piecewise review would be also be fine, just let us know what
you're reviewing. We've pre-requested reviews from some of you
already, but all comments welcomed by Aug 16th.
Webrev:
-------------
http://cr.opensolaris.org/~equach/webrev.ai-schema/
One high-level nit that I can't believe I didn't make during design
review: shouldn't we use <auto_install> as the top level tag in the
manifest?
We could.. I will have to coordinate this with Dermot because we have
coded this to be ai/ai_instance. I will talk to him about this.
I'm OK with this, but I want to be sure QE does a proper test
cycle with this fix included. Are you still planning to send them
a 2nd build, which include all the code review fixes?
- Dermot
sarah
Dave
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
