Hi Sue,
Most everything looks great now (thanks for taking the time to strip out
so many SystemExits). Just a few things left:
AI_database.py:
337-339: Leftover commented code
default.xml:
47: This should also remove pkg:/slim_install.
publish_manifest.py:
200: Nit: Seems like these are ints, not strings.
905: Just double-checking if this SystemExit was intended here or not.
1259: Should this tag check be updated?
set_criteria.py:
240: Should "raise SystemExit(1)" (or 2, or a message, etc.), or else
the program will exit with a successful return of 0.
- Keith
On 08/16/10 12:55 PM, Sue Sohn wrote:
Thanks to everyone for your comments. Below are pointers to updated
and incremental webrevs which address those comments. We'd appreciate
a quick turnaround on this one so that we can finish the review by COB
Wednesday, 8/18.
Webrev:
-------
Full webrev: http://cr.opensolaris.org/~sohn/webrev.ai-schema.v2/
Incr. webrev: http://cr.opensolaris.org/~sohn/webrev.ai-schema.v2.incr/
Note that the incremental webrev did not pick up the diffs for the
renamed publish_manifest.py file and instead shows all changes from
this project.
Thanks,
Sue
On 08/05/10 15:07, Ethan Quach wrote:
Hi all,
The following is the code review for the AI manifest schema changes,
and the installadm criteria changes. It is a rather large review, so
partial/piecewise review would be also be fine, just let us know what
you're reviewing. We've pre-requested reviews from some of you
already, but all comments welcomed by Aug 16th.
Webrev:
-------------
http://cr.opensolaris.org/~equach/webrev.ai-schema/
Bugs:
--------
16423 <http://defect.opensolaris.org/bz/show_bug.cgi?id=16423>
Updates to AI schema should be made
15449 <http://defect.opensolaris.org/bz/show_bug.cgi?id=15449>
installadm add validates combined manifest against image-specific
schema as well as schema in /usr/share/auto_install/
6975043 <http://bugs.opensolaris.org/view_bug.do?bug_id=6975043>
separate criteria and ai manifest
thanks,
-ethan
------------------------------------------------------------------------
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
