Hi Jack,

Thank for re-reviewing this. My comments inline..


Hi everyone.

Here are my round-2 comments:

auto-install/ai_manifest.xml:
-----------------------------

Nit: 36-37: get rid of "in the AI schema." It is too much info and is not needed.
Fixed.

192: ... full path is in the source/publisher/origin name.
Fixed.
Move 195 to just above 203
This is fixed. It was after this webrev was sent out.
205: The source/publisher/origin name corresponds to the directory...
Fixed.

206: software/software_data/name refers to the package name subdirectory...
Actually, it is source/publisher/origin that refers to it.
Move 211-212 to just above 219
Fixed.
222: The source/publisher/origin name refers to the path...
Move 227 to just above 233
Fixed.

default.xml:
------------

The <add_drivers> section is missing...

Added.
It can go between lines 49-50:

<!--
            Uncomment before using
<add_drivers>
<search_all/>
</add_drivers>
        -->

software.dtd
------------

Nit: 79: A facet is an option...

Fixed.

thanks,
sarah

_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to