On 08/26/10 08:47, Matt Keenan wrote:
Latest webrev now available at :
http://cr.opensolaris.org/~mattman/bug-14004/
This includes :
- Utility function for allocating targets in td_zpool.h to help with
memory freeing etc. (Dave)
- Remove all the compare functions and have just one compare function
now called compare_td_obj() (Sue)
- Update all ddm_get_*() calls to take and return a int * paramater
facilitating return of number of items discovered, thus removing the
count in each of the case sections of td_discover(). (Dave)
- Other general comments from Evan, Sue and Dave.
cheers
Matt
Hi Matt,
td_mg.c
95 - need to update comment
92, 100-104 - not sure you need the compare_routine as part of the struct now,
since it's always the same. Maybe remove it and use compare_td_obj in
sort_objs() on 2514
2404 - capitalize "return" and line up under "Compare" from line above
Thanks,
Sue
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
