Thanks Evan,
Changes made and new webrev posted :
http://cr.opensolaris.org/~mattman/bug-14004/
cheers
Matt
On 08/27/10 05:39 PM, Evan Layton wrote:
On 8/26/10 9:47 AM, Matt Keenan wrote:
Latest webrev now available at :
http://cr.opensolaris.org/~mattman/bug-14004/
This includes :
- Utility function for allocating targets in td_zpool.h to help with
memory freeing etc. (Dave)
- Remove all the compare functions and have just one compare function
now called compare_td_obj() (Sue)
- Update all ddm_get_*() calls to take and return a int * paramater
facilitating return of number of items discovered, thus removing the
count in each of the case sections of td_discover(). (Dave)
- Other general comments from Evan, Sue and Dave.
cheers
Matt
Just more nits... ;)
td_dd.c
nit: line 1338 it might be good to check dh for NULL before using it. I
know that this shouldn't ever be NULL since the handle is created before
this function is called. This is more of a just in case kind of thing.
td_zpool.c
nit: zpool_target_print didn't get renamed to td_zpool_target_print
another minor nit: some of the function comment blocks could still be
lined up better to make it more readable. for example:
424 * Parameters:
425 * zpool_handle_t *zlp : Current zpool handler
426 * void *data : List of discovered zpools
but this is just a minor nit so not a big deal…
test_td.c
nit: rename zpool_show_target to td_zpool_show_target and
zpool_show_attr to td_zpool_show_attr
Other than that it looks like you've covered all my previous comments
and it looks pretty good to me.
-evan
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
