On 08/31/10 12:35 PM, Chris Navrides wrote:
Hi all,
Could we please get a code review of the modifications made to
enable 6971585 Network Text Install
This will enable a client over the network to either do an Automated
Install or a Text Install. The default in the grub menu will lead to
the text install menu. For sparc if no "-install" flag is set then it
will also default to the text-install menu.
Webrev:
http://cr.opensolaris.org/~chris_n/netboot_text_instal
<http://cr.opensolaris.org/%7Echris_n/netboot_text_install/>l/
<http://cr.opensolaris.org/%7Echris_n/netboot_text_install/>
We have done testing with both x86 and sparc using the test bed on the
10.10.45 subnet. There are no changes done to installadm on the server
side.
Thanks,
Chris & Andrew
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
Hi guys,
First, a public congratulations on getting this far. I think you've done
well in getting this up and going in a way that minimally disrupts
existing installers.
That said, there's always room for improvement...
install-finish:
93-111: Since you're making modifications here, please change these
lines to the correct form of:
if o == '-X':
115-117: Echoing Clay's concern - if "-I" is omitted, this will raise a
NameError exception. INST_TYPE needs a default value assigned at line 70.
233-239: Since not installed packages are ignored, does this need to be
split up as such?
net-fs-root:
333: Nit: For clarity, I'd prefer to see this comparison reversed (i.e.,
check for "$ISA_INFO" == "sparc" and then do the SPARC related things).
336, 337, 345, 346: Replace "2> /dev/msglog" with "2>&1"
340: Nit: bookarchive -> boot archive
357, 358, 360, 361: In addition to the synchronous disable suggested by
Jan, the bug he recently fixed makes me wonder if TI_SMF_SETUP needs to
be enabled *before* disabled the console login service. I'm also curious
as to why the "svcadm refresh" command is needed.
ict.py:
1613: You'll want to change this to "pkg -R <basedir> info" to ensure
you're querying against the correct target. (Compare with line 1618, for
example)
perform_slim_install.c:
2326: I think it might be better to simply call
om_is_automated_installation() from within this function, rather than
make all the changes given.
- Keith
_______________________________________________
caiman-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
